fix: move ember-auto-import to dependencies#1208
Open
ro0gr wants to merge 1 commit intoAddepar:masterfrom
Open
fix: move ember-auto-import to dependencies#1208ro0gr wants to merge 1 commit intoAddepar:masterfrom
ro0gr wants to merge 1 commit intoAddepar:masterfrom
Conversation
so it can be used with the latest vertical-collection
There was a problem hiding this comment.
Pull request overview
This PR fixes a dependency configuration issue by moving ember-auto-import from devDependencies to dependencies in package.json. This is necessary for ember-table to work with the latest version of @html-next/vertical-collection, which requires addons to have ember-auto-import as a runtime dependency rather than a dev dependency.
Changes:
- Moved
ember-auto-importfromdevDependenciestodependenciesin package.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so it can be used with the latest vertical-collection.
Currently when I try upgrade vertical-collection, I get the following error:
According to https://github.com/embroider-build/ember-auto-import/tree/main?tab=readme-ov-file#installing-ember-auto-import-in-an-addon, auto-import should be moved to the
dependencies: